Skip to content

Use schema unification for item lists and improve support for empty item lists#1053

Open
mdekstrand wants to merge 6 commits intolenskit:mainfrom
mdekstrand:fix/empty-item-list
Open

Use schema unification for item lists and improve support for empty item lists#1053
mdekstrand wants to merge 6 commits intolenskit:mainfrom
mdekstrand:fix/empty-item-list

Conversation

@mdekstrand
Copy link
Member

This fixes and simplifies support for empty item lists by more thoroughly using Arrow schemas and schema unification, removing some special-case logic for empty item lists, and adding tests for the case where all lists in an item list collection are empty (#1051).

Closes #1051.

@mdekstrand mdekstrand added this to the 2026.1 milestone Mar 24, 2026
@mdekstrand mdekstrand self-assigned this Mar 24, 2026
@mdekstrand mdekstrand added breaking backport Backporting features to old release series. labels Mar 24, 2026
@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (2b50f02) to head (ede2ed4).

Files with missing lines Patch % Lines
src/lenskit/data/collection/_base.py 75.00% 3 Missing ⚠️
src/lenskit/data/items.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   89.67%   89.69%   +0.01%     
==========================================
  Files         223      182      -41     
  Lines       15476    13047    -2429     
==========================================
- Hits        13878    11702    -2176     
+ Misses       1598     1345     -253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting features to old release series. breaking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ItemListCollection.save_parquet fails when item lists are empty

1 participant