Code Refactoring + Improvements + Feature additions#1
Open
hemangshah wants to merge 4 commits intoleoiphonedev:masterfrom
Open
Code Refactoring + Improvements + Feature additions#1hemangshah wants to merge 4 commits intoleoiphonedev:masterfrom
hemangshah wants to merge 4 commits intoleoiphonedev:masterfrom
Conversation
UITextField proper alignment and corner margins.
Tried to minimal the code as much as possible.
- rename strCountryName to countryName as we can say that it's a string. - usage in cellForRowAt function - added self to the class variables for clear visibility and use - divide the tasks in functions for code check - changes the access specifiers for the require variables and constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the code to match the swift coding standards with minor logic improvements and features.
Updates:
PS. @leoiphonedev , nice work with this! 👍 I reached here after watching the video of this functionality on your YouTube channel. I have used your concept in my app to implement this live search functionality and made some more improvements in the code itself which I would like to share with you and for someone who will land here for the same solution.