Skip to content

Conversation

@mzeiher
Copy link

@mzeiher mzeiher commented Apr 1, 2019

This is a quick proof of concept on how to add type annotations for get/set properties, I could also add tests and cleanup as soon as I know how to your package is exactly organized :)

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #6 into master will decrease coverage by 5%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   91.89%   86.88%   -5.01%     
==========================================
  Files           4        4              
  Lines         111      122      +11     
  Branches       41       46       +5     
==========================================
+ Hits          102      106       +4     
- Misses          9       16       +7
Impacted Files Coverage Δ
src/metadata/metadataVisitor.ts 78.94% <57.14%> (-13.91%) ⬇️
src/metadata/serializeType.ts 85.13% <60%> (-4.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90bdd5...a726ec3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant