Skip to content

Update documentation2#3

Merged
leonieschweiger merged 17 commits intochemicalsfrom
update_documentation2
Aug 7, 2025
Merged

Update documentation2#3
leonieschweiger merged 17 commits intochemicalsfrom
update_documentation2

Conversation

@leonieschweiger
Copy link
Owner

@leonieschweiger leonieschweiger commented Jul 18, 2025

Purpose of this PR

@whitenightZhang I added documentation to the process-based chemicals implementation and updated specificFeDemands in datainput.gms. I also fixed a bug in postsolve.gms, leading to o37_shIndFE being the sum share of all process-based industry sectors, leading to wrong FE values for these sectors and summation errors.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ☑️ Documentation (GAMS incode documentation, comments, tutorials)
  • ☑️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ☑️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ☑️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@leonieschweiger leonieschweiger merged commit 8feccef into chemicals Aug 7, 2025
@leonieschweiger leonieschweiger deleted the update_documentation2 branch September 1, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant