-
Notifications
You must be signed in to change notification settings - Fork 299
fix: use consistent priority increment when skipping features #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: use consistent priority increment when skipping features #98
Conversation
…nzyl#65) The REST API skip endpoint was using max_priority + 1000, while the MCP server used max_priority + 1. This caused priority inflation where values could reach 10,000+ after multiple skips. Changed to use + 1 for consistency with mcp_server/feature_mcp.py:345. Fixes: leonvanzyl#65 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughA bug fix that modifies the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@server/routers/features.py`:
- Around line 554-556: The priority assignment here uses a different conditional
structure than other functions; change the calculation of feature.priority
(currently using max_priority and addition) to the same conditional-first
pattern used in create_feature and create_features_bulk by setting
feature.priority to (max_priority.priority + 1) if max_priority else 1 so it
matches the MCP server pattern and the rest of this file; locate the
max_priority variable and the assignment to feature.priority in this block
(referencing the Feature model and the surrounding priority logic) and update it
accordingly.
Address CodeRabbit feedback - use consistent conditional pattern: `(max_priority.priority + 1) if max_priority else 1` This matches the pattern used in create_feature and create_features_bulk. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
max_priority + 1000tomax_priority + 1Problem
When skipping a feature via UI, priority would jump to very high numbers (e.g., 1003→2003→3003...). After 10 skips, priorities could reach 10,000+. New features would then inherit these inflated numbers.
Root Cause
mcp_server/feature_mcp.py:345max_priority + 1server/routers/features.py:556max_priority + 1000Fix
Changed line 556 in
server/routers/features.pyfrom+ 1000to+ 1.Testing
Fixes #65
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.