Disallow whitespace in footnote identifiers#431
Merged
lepture merged 1 commit intolepture:mainfrom Feb 22, 2026
Merged
Conversation
The footnote regex used LINK_LABEL which permits spaces, tabs, and newlines. According to the PHP Markdown Extra spec, footnote identifiers must not contain whitespace. Introduce _FOOTNOTE_LABEL that excludes \s characters while keeping the same escaping rules. Fixes lepture#377
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 34 34
Lines 2637 2637
Branches 430 430
=======================================
Hits 2418 2418
Misses 147 147
Partials 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #377.
The footnote patterns (
REF_FOOTNOTEandINLINE_FOOTNOTE) usedLINK_LABELwhich permits spaces. According to the PHP Markdown Extra spec, footnote identifiers must not contain whitespace.Introduced a
_FOOTNOTE_LABELpattern that adds\sto the exclusion set, preventing[^foot note]from being parsed as a footnote reference while keeping[^footnote]working as expected.