fix: handle escaped dollar signs in inline math#438
Open
saschabuehrle wants to merge 1 commit intolepture:mainfrom
Open
fix: handle escaped dollar signs in inline math#438saschabuehrle wants to merge 1 commit intolepture:mainfrom
saschabuehrle wants to merge 1 commit intolepture:mainfrom
Conversation
The inline math pattern now correctly handles escaped $ characters within math expressions. Previously, $x=$$ would incorrectly parse as math 'x=\' followed by text '$', but now correctly parses as a single math expression 'x=$'. The fix uses a more precise regex pattern that matches either: - Non-dollar, non-backslash characters: [^$\] - Escaped sequences: \. This ensures that escaped $ characters are treated as literal content within the math expression rather than as delimiters.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Issue #370 — Escaped
$in inline math expressions are incorrectly parsed, causing the math expression to be split at the escaped dollar sign.Problem
The current inline math pattern
r"$(?!\s)(?P<math_text>.+?)(?!\s)$"uses a simple non-greedy match that doesn't handle escaped characters. For input like$x=\$$, it incorrectly parses as:x=\$Solution
Updated the pattern to
r"$(?!\s)(?P<math_text>(?:[^$\\]|\\.)+?)(?!\s)$"which:[^$\\]\\.\$characters are treated as literal content within math expressionsTesting
$x=\$$correctly as a single math expressionx=\$Greetings, saschabuehrle