Skip to content

Render expired on Authorizations when they are expired #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Render expired on Authorizations when they are expired #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions wfe/wfe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2017,6 +2017,14 @@ func (wfe *WebFrontEndImpl) Authz(
orderAcctID := authz.Order.AccountID
authz.Order.RUnlock()

// `pending` items should transition to `expired` if too old
// the context of this request is irrelevant
if authz.Status == acme.StatusPending {
if authz.ExpiresDate.Before(time.Now()) {
authz.Status = acme.StatusExpired
}
}

// If the postData is not a POST-as-GET, treat this as case A) and update
// the authorization based on the postData
if !postData.postAsGet {
Expand Down