Skip to content

test: add descending cursor direction pagination coverage #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kianjones9 wants to merge 1 commit into
base: kian/fix-desc-pagination-cursor
Choose a base branch
from
Open

test: add descending cursor direction pagination coverage #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/test_pagination_cursor_direction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
from letta_client.pagination import _next_cursor_params


def test_next_cursor_params_asc_forward_uses_after() -> None:
assert _next_cursor_params(params={"order": "asc"}, first_id="id-1", last_id="id-2") == {"after": "id-2"}


def test_next_cursor_params_desc_forward_uses_before() -> None:
assert _next_cursor_params(params={"order": "desc"}, first_id="id-1", last_id="id-2") == {"before": "id-1"}


def test_next_cursor_params_backward_stays_before_even_with_asc() -> None:
assert _next_cursor_params(
params={"order": "asc", "before": "id-0"}, first_id="id-1", last_id="id-2"
) == {"before": "id-1"}


def test_next_cursor_params_default_order_assumes_asc() -> None:
assert _next_cursor_params(params={}, first_id="id-1", last_id="id-2") == {"after": "id-2"}