Enhance CI local test runner to use SPIRE overlay build system#194
Merged
ramkri123 merged 1 commit intolfedgeai:mainfrom Feb 17, 2026
Merged
Conversation
Streamline integration testing by aligning test_control_plane.sh with the SPIRE overlay architecture introduced in commit dba010be. This enhancement enables seamless testing workflows in both CI and local development environments. Key improvements: - Update binary paths to use build/spire-binaries/ output location - Modernize build detection to check overlay patches instead of source - Replace legacy Makefile build with scripts/spire-build.sh invocation - Improve build error diagnostics with clearer troubleshooting steps - Maintain backward compatibility with existing CI workflows This change removes the need for CI-specific symlink workarounds and ensures consistent behavior between automated CI runs and manual testing sessions. Developers can now run tests directly after building with the overlay system without additional setup steps. Testing: Verified on both fresh clones and existing workspaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Streamlines our integration testing by aligning
test_control_plane.shwith the SPIRE overlay build architecture. This enhancement ensures seamless testing workflows in both CI and local development environments without requiring CI-specific workarounds.Motivation
As we've modernized our SPIRE integration to use the overlay system (introduced in commit dba010be), our testing infrastructure needed alignment to work naturally with the new build outputs. This change makes local testing workflows match CI behavior without additional setup steps.
Changes
Binary Path Updates
hybrid-cloud-poc/spire/bin/spire-serverbuild/spire-binaries/spire-serverBuild System Integration
hybrid-cloud-poc/spire/scripts/spire-build.sh(overlay build system)Smarter Rebuild Detection
.gofiles changed in source treeImproved Diagnostics
/tmp/spire-overlay-build.logfor debuggingTesting
Verified on:
python ci_test_runner.pyexecutionBackward Compatibility
This change maintains compatibility with existing CI workflows. The
.github/workflows/ci.ymlsymlink creation steps can now be considered optional (kept for extra safety) since tests work directly with overlay build outputs.Commands to Test
Impact
Checklist
Commit:
0aa13eae- "Enhance CI test runner to use SPIRE overlay build system"