Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have addressed issues discussed in #111 and #152. All changes are relating to
plot2D. Changes are:Addition of UMAP:
plot2Dfunction.umapin CRAN as discussed originally in issue Consider using UMAP embedding method #111. I feel it meets our needs and defaults work pretty well for LOPIT data.methargsas we would for t-SNE. I have also added an example to the intro vignetteNew/changes to arguments in
plot2Dgrid = TRUEas the defaultdev.newinaddLegend. Instead of plotting a device in a new window, plots the legend in the default plot space.bgfilling of points parameter as is implemented inparlwdspecification of the line widthpalettespecify "light" or "dark", helps users generate nice colour palette for point filled characters. Uses thelightenanddarkenfunctions fromcolorspacepackage.tcontrols degree of lightening ofpalette(fromcolorspace)stockpchis nowc(21:25, 1, 15, 0, 17, 2, 18, 5, 7, 9, 13, 3, 4, 8)to allow filled point characters by defaultgetStockbgand friends see here and updated docs to aid in the above.Unit tests:
@lgatto There doesn't seem to be any breaking changes. All vignettes run and plots are generated in the new style with no issues. Package passed build, check and install. Appreciate this is very last minute but would be great to have this in the new release if possible.