Upgrade to libdns v1.1.1 and adjust tests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove manual ID assignment (handled automatically by getRecordId) - Simplify tests to work with Record interface - Tests now compile and are ready for libdns v1.1.1
jhf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades libdns/namedotcom to work with libdns v1.1.1 (addresses #3)
Changes
Credits
Based on the work by @ykarachev in his upgrade PR. Fixed test suite for compatibility with Record interface.
Testing
Resolves #3
Enables: caddy-dns/namedotcom#5