feat(settings): connection toggles in Downloads & Sharing + mdns i18n#28
Open
feat(settings): connection toggles in Downloads & Sharing + mdns i18n#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small changes in the same logical area — Settings → Downloads & Sharing.
What changes
useRelayClients(default ON) betweenmaxRelayReservationsandmaxRelayClients. When OFF, the node no longer reserves slots on foreign relays (discoverRelays: 0, no/p2p-circuitlisten slots).autoConnectNewNetworks(default ON). When ON, networks added vialishnets.addandlishnets.addIfNotExistsare immediatelyenabled=trueand alishnets:joinedbroadcast is emitted — the user no longer has to click a follow-up button.mdnsEnabledandmdnsInterval— these last two settings rows previously rendered as raw keys.Commits
Backwards compatibility
Both new settings default to `true` and tolerate absence in older `settings.json` (`?? true` in the frontend, `!== false` in the backend). DB schema unchanged, existing relays/networks untouched.