Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
• Update import paths across 58 files to replace internal wallet, balance, network, provider, addressbook, trezor, and ledger logic with external @yellow-dev/crypto-utils modules. • Remove redundant internal implementations (e.g. wallet.ts, balance.ts, provider.ts, ledger-transaction.ts, trezor.ts) now provided by crypto-utils. • Adjust package.json dependencies to load yellow-client-common and crypto-utils from GitHub. • Revise several Svelte components and dialogs so that wallet functionality now consistently leverages the new crypto-utils package for clearer separation and maintenance.
- Adjust BaseSettings layout by removing padding and adding margin for cleaner display - Enhance LedgerConnect: add device instructions and remove redundant error block - Improve TrezorConnect: disable auto-initialization call, show connected device info, add troubleshooting tips, and update debug logging - Refine logging in Balance.svelte when switching networks - Update Wallet.svelte to open the correct settings section for HW wallet addition - Tweak SettingsWalletsAddHWWalletTrezor buttons layout and debug info display
• Integrate the QRScanner component with toggle UI and error handling • Parse and apply QR code data using a new payment-qr module (addresses, amount, chainID) • Prevent sending when QR chainID does not match the current network, and offer network switching • Update Wallet page to use networksWindow for network selection dialogs
• Add support for contractAddress in QR parsing and payment URL generation • Refactor Receive and Send pages to use generatePaymentURL for both native and ERC-20 payments • Enhance Send page network mismatch alerts with dynamic network names and add “Add Token” action • Pre-fill contract address in token add/edit settings when QR provides contract info • Insert an extra tick in BaseSettings to ensure proper async component updates • Update Svelte store typings for settings, wallets, RPC servers, and networks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.