New compute methods for vSphere, storage operations by instance ID, misc vSphere fixes#23
Open
harsh-px wants to merge 2 commits intolibopenstorage:masterfrom
Open
New compute methods for vSphere, storage operations by instance ID, misc vSphere fixes#23harsh-px wants to merge 2 commits intolibopenstorage:masterfrom
harsh-px wants to merge 2 commits intolibopenstorage:masterfrom
Conversation
…isc vSphere fixes - Fix error types for vSphere when disk is not attached - Add InspectInstance implementation for vSphere - Add new methods, ListInstances, CreateInstance, AttachByInstanceID - DeviceMappings can now be done by instance ID - Remove timeout from DeleteInstance. Callers should use exponentional backoff instead - Add attach options to Attach method Signed-off-by: Harsh Desai <harsh@portworx.com>
Signed-off-by: Harsh Desai <harsh@portworx.com>
Contributor
|
Can you split the vendor code and the actual cloudops changes into different commits ? |
adityadani
reviewed
Aug 16, 2019
| err error | ||
| ) | ||
|
|
||
| if len(instanceID) == 0 { |
Contributor
There was a problem hiding this comment.
I think we should define a constant Local and error out if instanceID is empty.
The API is confusing when there is added intelligence if a param is not given.
You can also just add a new API like the other ones - DeviceMappingsForInstance
| // GetDeviceID returns ID/Name of the given device/disk or snapshot | ||
| GetDeviceID(template interface{}) (string, error) | ||
| // Attach volumeID. | ||
| // options are passthough options given to the cloud provider |
| } | ||
|
|
||
| _, err = task.DoRetryWithTimeout(f, timeout, retrySeconds*time.Second) | ||
| _, err = task.DoRetryWithTimeout(f, 2*time.Minute, retrySeconds*time.Second) |
Contributor
There was a problem hiding this comment.
nit: add this as a constant.
| require.NotNil(t, info, "got nil instance info from inspect") | ||
| require.NotEmpty(t, info.Zone, "inspect must returns instance zone") | ||
|
|
||
| instances, err = driver.ListInstances(&cloudops.ListInstancesOpts{ |
Contributor
There was a problem hiding this comment.
Can add a UT using LabelSelectors
| StoragePod string | ||
| // Datastore is the VMFS datastore to use for the VM | ||
| Datastore string | ||
| // ResourcePool is the resource pool to use to place to VM |
Contributor
There was a problem hiding this comment.
nit: ResourcePool is the resource pool where the VM is placed
| return folder, nil | ||
| } | ||
|
|
||
| func (ops *vsphereOps) getFinderAndDC(ctx context.Context, datacenter string) ( |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| func (ops *vsphereOps) getFinderAndDC(ctx context.Context, datacenter string) ( | |
| func (ops *vsphereOps) getFinderAndDC( | |
| ctx context.Context, | |
| datacenter string, | |
| ) (*find.Finder, *object.Datacenter, error) { |
| } | ||
|
|
||
| func (ops *vsphereOps) ListInstances(opts *cloudops.ListInstancesOpts) ( | ||
| []*cloudops.InstanceInfo, error) { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| []*cloudops.InstanceInfo, error) { | |
| func (ops *vsphereOps) ListInstances( | |
| opts *cloudops.ListInstancesOpts, | |
| ) ([]*cloudops.InstanceInfo, error) { |
|
|
||
| var datacenter string | ||
| if opts != nil && opts.LabelSelector != nil { | ||
| datacenter = opts.LabelSelector["datacenter"] |
Contributor
There was a problem hiding this comment.
nit: "datacenter" seems to be used at multiple places. It can be a constant.
| return false, err | ||
| } | ||
|
|
||
| return o.Runtime.ConnectionState != "invalid", nil |
Contributor
There was a problem hiding this comment.
Aren't there any constants defined in vsphere library for such states?
| return o.Config.Name, nil | ||
| } | ||
|
|
||
| // We treat a VM's zone as the vSphere cluster in which the vm resizes. |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| // We treat a VM's zone as the vSphere cluster in which the vm resizes. | |
| // We treat a VM's zone as the vSphere cluster in which the vm resides. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Desai harsh@portworx.com