remove test results mount from stork integration test container#1485
Open
Rohit-PX wants to merge 1 commit intolibopenstorage:masterfrom
Open
remove test results mount from stork integration test container#1485Rohit-PX wants to merge 1 commit intolibopenstorage:masterfrom
Rohit-PX wants to merge 1 commit intolibopenstorage:masterfrom
Conversation
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
Collaborator
|
Can one of the admins verify this patch? |
88d7c76 to
56a4e96
Compare
Contributor
diptiranjanpx
left a comment
There was a problem hiding this comment.
Can we mount the /testresults directory in the spec so that the directory is already available and no need to create it ? it can be an alternative. If at all we are not using the result, then it looks fine to remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
integration-test
What this PR does / why we need it:
testresultsdirectory butdoes not have adequate permissions
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no
Does this change need to be cherry-picked to a release branch?:
no