Open
Conversation
added 2 commits
November 28, 2023 21:30
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
Rohit-PX
requested review from
adityadani,
diptiranjanpx,
gejain,
olavangad-px and
pp511
Collaborator
|
Can one of the admins verify this patch? |
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
pp511
reviewed
Dec 1, 2023
| projectIDMappings string, | ||
| namespaceLabels map[string]string, | ||
| ) ([]*scheduler.Context, *scheduler.Context) { | ||
| log.InfoD("Schedule mysql app") |
Contributor
There was a problem hiding this comment.
It will not always be mysql app. We should be printing the appKey instead
|
|
||
| err = schedulerDriver.WaitForRunning(ctxs[0], defaultWaitTimeout, defaultWaitInterval) | ||
| require.NoError(t, err, "Error waiting for app to get to running state") | ||
| log.InfoD("Mysql app validated") |
| } | ||
|
|
||
| func deploymentMigrationTest(t *testing.T) { | ||
| dash.TestCaseBegin("Deployment migration test", "Validating Async DR with Deployment App", "", nil) |
Contributor
There was a problem hiding this comment.
We need to pass testrailID as the third param here right?
| err = scheduleUnidirectionalClusterPair(remotePairName, clusterPairNamespace, projectIDMappings, defaultBackupLocation, defaultSecretName, true, pairReverse) | ||
| require.NoError(t, err, "failed to set unidirectional cluster pair: %v", err) | ||
| } else { | ||
| log.InfoD("Scheduling cluster pair using storkctl generate") |
Contributor
There was a problem hiding this comment.
We should be using storkctl create and not generate. Isn't it?
| } | ||
|
|
||
| func equalPodSpreadTest(t *testing.T) { | ||
| dash.TestCaseBegin("Stork scheduler equal pod spread test", "Verify equal pod spread is achieved using stork for an app", "", nil) |
Contributor
There was a problem hiding this comment.
same concern about first param as above. Similar concern everywhere else.
| } | ||
|
|
||
| func preferRemoteNodeFalseHyperconvergenceTest(t *testing.T) { | ||
| dash.TestCaseBegin("Stork scheduler prefer remote node antihyperconvergence test", "validate antihyperconvergence with preferRemoteNodeOnly flag", "", nil) |
Contributor
There was a problem hiding this comment.
Shouldn't we be passing the exact name of the test as the first param instead of a brief description?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
integration-test
What this PR does / why we need it:
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no
Does this change need to be cherry-picked to a release branch?:
no