Open
Conversation
Collaborator
|
Can one of the admins verify this patch? |
gejain
force-pushed
the
topic/geet/storkctlclusterpairoptions
branch
from
9822df9 to
17965c7
Compare
gejain
force-pushed
the
topic/geet/storkctlclusterpairoptions
branch
from
17965c7 to
f30e510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
We have created a matrix for clusterpair options and trying to get automate the tests with mandatory and optional options for clusterpair creation. As of now just add 4 tests -
TestStorkCtlClusterPair/createClusterPairWithEncKeydisableSSLTest
TestStorkCtlClusterPair/createClusterPairWithoutEncKeydisableSSLTest
TestStorkCtlClusterPair/createClusterPairWithEpTest
TestStorkCtlClusterPair/createClusterPairSyncDrTest
Does this PR change a user-facing CRD or CLI?:
No
TestRun Results -
--- PASS: TestStorkCtlClusterPair (1106.55s)
--- PASS: TestStorkCtlClusterPair/createClusterPairWithEncKeydisableSSLTest (237.50s)
--- PASS: TestStorkCtlClusterPair/createClusterPairWithoutEncKeydisableSSLTest (239.09s)
--- PASS: TestStorkCtlClusterPair/createClusterPairWithEpTest (463.49s)
--- PASS: TestStorkCtlClusterPair/createClusterPairSyncDrTest (162.24s)