Replace rand() with fixed-seed RNG to make tests deterministic#344
Open
alienx5499 wants to merge 1 commit intolibp2p:masterfrom
Open
Replace rand() with fixed-seed RNG to make tests deterministic#344alienx5499 wants to merge 1 commit intolibp2p:masterfrom
alienx5499 wants to merge 1 commit intolibp2p:masterfrom
Conversation
128c11d to
ef3b0a9
Compare
ef3b0a9 to
6eac084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces unseeded rand() in tests with a shared fixed-seed RNG to make test runs deterministic and reproducible, preventing flaky CI failures.
Why
Unseeded randomness causes flaky tests and non-reproducible CI failures.
What changed
testutil::randomBytes()andgetTestRng()intest/testutil/libp2p/random.hpp.rand()usage in:test/testutil/libp2p/peer.cpptest/libp2p/transport/tcp/tcp_integration_test.cpptest/libp2p/crypto/marshaller_test.cpptest/libp2p/protocol/kademlia/peer_routing_table_test.cppImpact
Note
The RNG is shared (static); test execution order affects the byte sequence. Determinism is per run, not per test. See comment in
random.hpp.