Skip to content

feat(lxl-web): Add keyboard shortcut help for expanding search#1565

Open
johanbissemattsson wants to merge 3 commits intodevelopfrom
feat-lxlweb-keyboard-shortcut-help-for-expand-search
Open

feat(lxl-web): Add keyboard shortcut help for expanding search#1565
johanbissemattsson wants to merge 3 commits intodevelopfrom
feat-lxlweb-keyboard-shortcut-help-for-expand-search

Conversation

@johanbissemattsson
Copy link
Copy Markdown
Contributor

@johanbissemattsson johanbissemattsson commented Apr 20, 2026

Description

Solves

Add keyboard shortcut help for expanding search.

Skärmavbild 2026-04-20 kl  11 23 43

Summary of changes

  • Add keyboard shortcut help for expanding search

Copy link
Copy Markdown
Contributor

@jesperengstrom jesperengstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended.
But I think we should maybe ask users about this too - to what extent it's helpful or comprehensible. Must be careful not to overload the search area.

  • Novice users would need to hover this to understand what it's doing, somewhat contradictory if you want to use keyboard only?
  • Pro users would just start typing the name of a filter they like to add, no need to simply expand the search?

But i'm totally fine with trying this out.

Copy link
Copy Markdown
Contributor

@olovy olovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think the text should be e.g. "Gå till sökruta" or similar.
The point is selecting the search field without clicking, nor that it is expanded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants