Skip to content

Conversation

ColinKinloch
Copy link
Contributor

@ColinKinloch ColinKinloch commented Aug 16, 2025

The AVVulkanDeviceQueueFamily struct was introduced by libavutil 59.34.100: FFmpeg/FFmpeg@13489c8 .

This test would fail to build with FFmpeg 7.0.3 "Dijkstra", for example flatpak org.freedesktop.Platform//24.08.

You can test this with:

flatpak install org.freedesktop.Sdk//24.08
flatpak run --filesystem="$(pwd)" org.freedesktop.Sdk//24.08 -c 'cmake -B _build_fp -G Ninja -DSDL_TESTS=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=ON'
flatpak run --filesystem="$(pwd)" org.freedesktop.Sdk//24.08 -c 'cmake --build _build_fp'
SDL_LOGGING=system=debug flatpak run --devel --filesystem="$(pwd)" --device=dri --socket=wayland org.freedesktop.Sdk//24.08 -c './_build_fp/test/testffmpeg'

The `AVVulkanDeviceQueueFamily` struct was introduced by libavutil
59.34.100
@sezero sezero requested a review from slouken August 20, 2025 02:05
@slouken slouken merged commit 81920b5 into libsdl-org:main Aug 25, 2025
41 checks passed
@slouken
Copy link
Collaborator

slouken commented Aug 25, 2025

Merged and cherry-picked, thanks!

@ColinKinloch ColinKinloch deleted the vulkan_qf_version_check branch August 25, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants