Conversation
Member
|
Good catch, how did that ever build? o_O |
|
Building without error now, also resolves several warnings. Don't have hardware to test it. |
When compiling C (not C++), and a function is not declared with parameters, nor void, the parameters are undefined: #include <stdio.h>
void foo();
void bar(void);
int main(int argc, char *argv[])
{
foo(1);
bar(2);
return 0;
}Will only give error on the call to bar: |
mywave82
requested changes
Apr 23, 2025
mywave82
left a comment
There was a problem hiding this comment.
Looks good to me. Adding a void in the header file would make it even more complete.
int xSfw_dlopen(void);
void xSfw_dlclose(void);
Member
Got it, it "worked" because we're building with a C++ compiler. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't error out here but the call is indeed wrong.