Fix #3

[rdoursenaud]

Commit ee9f6f4 contains a few fixes suggested by CLion static analysis.
Feel free to not include them if you don't feel like it.

Commit 53a17d2 contains the logic changes presented in #3 (comment).

[smclt30p]

I will test this once I get home later today with my X220, It should work from the looks of it. Thanks for the PR! :)

[smclt30p]

On Wed, Jan 17, 2018 at 02:31:46AM +0000, Raphaël Doursenaud wrote: Commit ee9f6f4 contains a few fixes suggested by CLion static analysis. Feel free to not include them if you don't feel like it. Commit 53a17d2 contains the logic changes presented in #3 (comment). You can view, comment on, or merge this pull request online at: #4 -- Commit Summary -- * Fixes suggested by CLion static analysis * Make resolution change more robust -- File Changes -- M crtc.cpp (82) M main.cpp (4) -- Patch Links -- https://github.com/libthinkpad/dockd/pull/4.patch https://github.com/libthinkpad/dockd/pull/4.diff

I just tested the patch and I experience regression on my system. When undocking X.Org hangs and when docking I have 2 on, but blank screens. When undocking it seems like you did not ungrab the screen, and on docking it's a general mess.

…

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #4

[smclt30p]

The screen size must be set AFTER altering the crtc config in any way.

So disable configs, set screen size, enable configs, set screen size

[rdoursenaud]

Yes, something's wrong even on my system.
It was a late night quick and dirty hack ;)
I'll try and have a better look ASAP.

[smclt30p]

On Tue, Jan 30, 2018 at 06:59:19PM -0800, Raphaël Doursenaud wrote: Yes, something's wrong even on my system. It was a late night quick and dirty hack ;) I'll try and have a better look ASAP.

Sure, just send it in.

…

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #4 (comment)