More integration tests #1552
Merged
More integration tests #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: b0a7bec Minimum allowed coverage is ♻️ This comment has been updated with latest results |
folkyatina
reviewed
Nov 25, 2025
| }); | ||
|
|
||
| describe("Oracle fee reporting", () => { | ||
| it("reverts when oracle attempts to decrease cumulative fees", async () => { |
Member
There was a problem hiding this comment.
high border sanity check test
| await vaultHub.connect(agentSigner).grantRole(await vaultHub.VAULT_MASTER_ROLE(), vaultMaster); | ||
|
|
||
| // loosen sanity checks to bypass fee increase rate limit | ||
| await ctx.contracts.lazyOracle.connect(agentSigner).updateSanityParams(days(30n), 1000n, 1000000000000000000n); |
Member
There was a problem hiding this comment.
let's not disable a sanity check
| const treasuryBefore = await ethers.provider.getBalance(await ctx.contracts.locator.treasury()); | ||
|
|
||
| const tx = await vaultHub.settleLidoFees(stakingVault); | ||
| await tx.wait(); |
Member
There was a problem hiding this comment.
Suggested change
| await tx.wait(); |
| expect(treasuryAfter - treasuryBefore).to.equal(ether("2")); | ||
| }); | ||
|
|
||
| it("respects locked balance", async () => { |
Member
There was a problem hiding this comment.
Maybe add locked+redemptions case
| expect(await vaultHub.isPendingDisconnect(stakingVault)).to.be.true; | ||
| }); | ||
|
|
||
| it("allows fee settlement during disconnect process", async () => { |
| }); | ||
|
|
||
| describe("Bad debt scenarios", () => { | ||
| it("handles large unpaid fees with bad debt", async () => { |
Member
There was a problem hiding this comment.
Suggested change
| it("handles large unpaid fees with bad debt", async () => { | |
| it("revert settling if bad debt", async () => { |
| waitForNextRefSlot: true, | ||
| }); | ||
|
|
||
| const maxLockableAfter = await vaultHub.maxLockableValue(stakingVault); |
Member
There was a problem hiding this comment.
better to check capacity not maxLockable value
| const obligationsAfter = await vaultHub.obligations(stakingVault); | ||
| expect(obligationsAfter.feesToSettle).to.equal(0n); // All fees settled | ||
|
|
||
| const maxLockableAfter = await vaultHub.maxLockableValue(stakingVault); |
Member
There was a problem hiding this comment.
Maybe check capacity here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/Testnet-3-test-plan-27dbf633d0c98068b1f3f261b9c0e712#28dbf633d0c9809ba6d4de23a29baad0