nirsh by nirshif · Pull Request #11 · lidorg-dev/hello-world-war

nirshif · 2022-11-26T19:17:34Z

No description provided.

sonatype-lift · 2022-11-26T19:20:28Z

Dockerfile

+# clone repo
+WORKDIR  /tmp/repos
+RUN git clone https://github.com/nirshif/hello-world-war.git
+RUN cd /tmp/repos/hello-world-war && git checkout ns-es


DL3003: Use WORKDIR to switch to a directory

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-26T19:20:30Z

Dockerfile

@@ -0,0 +1,43 @@
+FROM ubuntu


DL3006: Always tag the version of an image explicitly

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-26T19:20:32Z

Dockerfile

+FROM ubuntu
+
+# Install prerequisites
+RUN apt-get -y update && apt-get -y upgrade


DL3009: Delete the apt-get lists after installing something

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-26T19:20:35Z

Dockerfile

+RUN mkdir /opt/tomcat/
+RUN mkdir /opt/webapp/
+RUN mkdir /tmp/repos
+RUN wget https://dlcdn.apache.org/tomcat/tomcat-9/v9.0.65/bin/apache-tomcat-9.0.65.tar.gz -O /tmp/tomcat.tar.gz


DL3047: Avoid use of wget without progress bar. Use wget --progress=dot:giga <url>.Or consider using -q or -nv (shorthands for --quiet or --no-verbose).

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-26T19:20:36Z

Dockerfile

+# run war in tomcat
+WORKDIR /opt/tomcat/webapps
+
+CMD ["/opt/tomcat/bin/catalina.sh", "run"]


DL4003: Multiple CMD instructions found. If you list more than one CMD then only the last CMD will take effect

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-26T19:20:38Z

Dockerfile

+
+# Install prerequisites
+RUN apt-get -y update && apt-get -y upgrade
+RUN apt-get -y install openjdk-8-jdk wget


💬 3 similar findings have been found in this PR

DL3008: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

🔎 Expand here to view all instances of this finding

File Path Line Number

Dockerfile 6

Dockerfile 7

Dockerfile 8

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-26T19:20:40Z

Dockerfile

+
+# Install prerequisites
+RUN apt-get -y update && apt-get -y upgrade
+RUN apt-get -y install openjdk-8-jdk wget


💬 3 similar findings have been found in this PR

DL3015: Avoid additional packages by specifying --no-install-recommends

🔎 Expand here to view all instances of this finding

File Path Line Number

Dockerfile 6

Dockerfile 7

Dockerfile 8

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-26T19:20:42Z

Dockerfile

+# Install prerequisites
+RUN apt-get -y update && apt-get -y upgrade
+RUN apt-get -y install openjdk-8-jdk wget
+RUN apt-get -y install curl


💬 7 similar findings have been found in this PR

DL3059: Multiple consecutive RUN instructions. Consider consolidation.

🔎 Expand here to view all instances of this finding

File Path Line Number

Dockerfile 7

Dockerfile 8

Dockerfile 9

Dockerfile 10

Dockerfile 11

Dockerfile 12

Dockerfile 28

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

hunter1982 and others added 14 commits July 27, 2022 12:00

add dockerfile

293ef16

fix dock file

991f5ec

testing

3875edd

edit

c96cc6f

edit

19c1dc7

edit

9b73035

edit

1812bdb

edit

70613d3

edit

f49c182

ddd

3d17c15

ddd

c9246e4

ddd

641e220

ddd

121e581

Merge branch 'lidorg-dev:master' into ns-es

dfa97ce

sonatype-lift bot reviewed Nov 26, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nirsh#11

nirsh#11
nirshif wants to merge 14 commits intolidorg-dev:masterfrom
nirshif:ns-es

nirshif commented Nov 26, 2022

Uh oh!

sonatype-lift bot Nov 26, 2022

Uh oh!

sonatype-lift bot Nov 26, 2022

Uh oh!

sonatype-lift bot Nov 26, 2022

Uh oh!

sonatype-lift bot Nov 26, 2022

Uh oh!

sonatype-lift bot Nov 26, 2022

Uh oh!

sonatype-lift bot Nov 26, 2022

Uh oh!

sonatype-lift bot Nov 26, 2022

Uh oh!

sonatype-lift bot Nov 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

Conversation

nirshif commented Nov 26, 2022

Uh oh!

sonatype-lift bot Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants