Skip to content

patch: clean main#291

Open
danielboloc wants to merge 41 commits intomainfrom
clean-main
Open

patch: clean main#291
danielboloc wants to merge 41 commits intomainfrom
clean-main

Conversation

@danielboloc
Copy link
Collaborator

@danielboloc danielboloc commented Jan 28, 2026

Overview

Refactors click commands into separate files and completes CIs to run all commands

JIRA

Please add here as many related tasks this PR covers with its brief description, if more than one ticket

Changes

Refactors commands into separate files and imported only into main

  • Each module now has a new file for example cloudos_cli/jobs/cli.py where all the commands and subcommands are held

CI/CD Improvements (.github/workflows/ci.yml)

  • Removed hardcoded job IDs - All tests now use dynamic job dependencies
  • Added job outputs - job_run_and_status, bash_job, bash_array_job now output job_ids
  • New CI tests: job_run_and_abort, job_resume, configure_profile
  • Improved job dependencies - delete_workdir now depends on both job_workdir and job_resume
  • Self-contained CI - No external workspace dependencies needed

Acceptance Criteria

PROD

CIs are now adding more functionality and test all commands (except link which is tested in the IA section). Therefore, manual tests are not performed for this workspace.

DEV

This Environment is interchangable with PROD if the acceptance criteria can only be tested in DEV for example. If that is the case please name this section PROD (or any new environment)

Proof this feature/patch works in this environment

Running job
image
image

Cloning job
image
image

Resuming job
image
image

AZURE

Proof this feature/patch works in this environment

Running job
image
image

Cloning job
image
image

Resuming job
image
image

Interactive Analysis

Proof this feature/patch works in this environment

Linking
image
image

@danielboloc danielboloc changed the title Clean main patch: clean main Jan 28, 2026
@danielboloc danielboloc marked this pull request as ready for review January 28, 2026 13:39
@danielboloc danielboloc marked this pull request as draft January 28, 2026 14:35
@danielboloc danielboloc marked this pull request as ready for review January 28, 2026 14:36
@danielboloc danielboloc marked this pull request as draft January 28, 2026 15:45
@danielboloc danielboloc marked this pull request as ready for review January 28, 2026 15:45
@danielboloc danielboloc marked this pull request as draft January 29, 2026 13:45
@danielboloc danielboloc marked this pull request as ready for review January 29, 2026 13:45
@danielboloc danielboloc marked this pull request as draft January 29, 2026 14:18
@danielboloc danielboloc marked this pull request as ready for review January 29, 2026 14:18
@danielboloc danielboloc marked this pull request as draft January 29, 2026 14:19
@danielboloc danielboloc marked this pull request as ready for review January 29, 2026 14:20
@danielboloc danielboloc marked this pull request as draft January 29, 2026 14:28
@danielboloc danielboloc marked this pull request as ready for review January 29, 2026 14:28
@danielboloc danielboloc marked this pull request as draft January 29, 2026 14:44
@danielboloc danielboloc marked this pull request as ready for review January 29, 2026 14:44
@danielboloc danielboloc marked this pull request as draft February 11, 2026 13:11
@danielboloc danielboloc marked this pull request as ready for review February 11, 2026 13:11
danielboloc and others added 3 commits February 11, 2026 16:20
Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com>
Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com>
@danielboloc danielboloc marked this pull request as draft February 11, 2026 15:29
@danielboloc danielboloc marked this pull request as ready for review February 11, 2026 15:29
@danielboloc danielboloc marked this pull request as draft February 12, 2026 11:43
@danielboloc danielboloc marked this pull request as ready for review February 12, 2026 11:43
@danielboloc danielboloc marked this pull request as draft February 12, 2026 13:08
@danielboloc danielboloc marked this pull request as draft February 12, 2026 13:08
@danielboloc danielboloc marked this pull request as ready for review February 12, 2026 13:08
@danielboloc danielboloc marked this pull request as draft February 12, 2026 14:56
@danielboloc danielboloc marked this pull request as ready for review February 12, 2026 14:57
@danielboloc
Copy link
Collaborator Author

@l-mansouri thanks for the review

  • Good catch about the --debug, I have updated it in all commands

@dapineyro thanks for the review

  • I have removed empty lines and with f'string' and left pytests for python versions 3.9, 3.11 and 3.13, but other CIs to only 3.9

General observations:

  • I have noticed that job list --filter-queue stopped working mainly because now api/v2/jobs is not returning batch field (at least in my quick investigation). Opened a new issue --filter-queue options gives errror #292 to keep track and possibly do an independent PR fix. I have 'disabled' this CI until the issue is solved

CI workspace
image

ADAPT workspace
image

main branch in ADAPT
image

Copy link
Collaborator

@dapineyro dapineyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Huge improvement @danielboloc , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants