Skip to content

MSRV 1.87 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hombit wants to merge 9 commits into from
Closed

MSRV 1.87 #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a3e98ca
Rust version 1.87
hombit Nov 3, 2025
79a6b3f
sys: edition 2024
hombit Nov 3, 2025
fe1acb0
CI: use 1.87 for MSRV tests
hombit Nov 18, 2025
e96d053
cargo fmt
hombit Nov 18, 2025
7cc0c9c
Initial plan
Copilot Dec 12, 2025
e47ca9d
Keep ceres-solver-sys on edition 2021 due to cxx 1.0.x incompatibilit…
Copilot Dec 13, 2025
5d157a1
Change to edition 2021 for all crates, keep MSRV 1.87
Copilot Dec 13, 2025
a01b7ff
Update ceres-solver-sys MSRV to 1.87.0
Copilot Dec 13, 2025
55a9929
Merge pull request #76 from light-curve/copilot/sub-pr-70
hombit Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
# glog/log_severity.h(57): fatal error C1189: #error: ERROR macro is defined. Define
# GLOG_NO_ABBREVIATED_SEVERITIES before including logging.h. See the document for detail.
os: [ "ubuntu-latest", "macos-latest" ]
rust_toolchain: [ "1.67", "stable" ]
rust_toolchain: [ "1.87", "stable" ]

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
matrix:
# Help needed for Windows, vcpkg builds it, but I don't know how to make it discoverable
os: [ "ubuntu-latest", "macos-latest" ]
rust_toolchain: [ "1.67", "stable" ]
rust_toolchain: [ "1.87", "stable" ]

steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 3 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]
name = "ceres-solver"
version = "0.4.0"
version = "0.5.0"
edition = "2021"
readme = "README.md"
description = "Safe Rust bindings for the Ceres Solver"
repository = "https://github.com/light-curve/ceres-solver-rs"
license = "MIT OR Apache-2.0"
rust-version = "1.67.0"
rust-version = "1.87.0"
exclude = [".github"]

[workspace]
Expand All @@ -22,7 +22,7 @@ source = ["ceres-solver-sys/source"]
default = ["system"]

[dependencies.ceres-solver-sys]
version = "0.4.0"
version = "0.5.0"
path = "./ceres-solver-sys"

[dependencies.thiserror]
Expand Down
8 changes: 4 additions & 4 deletions ceres-solver-sys/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]
name = "ceres-solver-sys"
version = "0.4.2"
version = "0.5.0"
edition = "2021"
readme = "README.md"
description = "Unsafe Rust bindings for the Ceres Solver"
repository = "https://github.com/light-curve/ceres-solver-rs"
license = "MIT OR Apache-2.0"
rust-version = "1.67.0"
rust-version = "1.87.0"

[features]
system = ["pkg-config"]
Expand All @@ -20,12 +20,12 @@ path = "../ceres-solver-src"
optional = true

[dependencies.cxx]
version = "1,<=1.0.129" # 1.0.130 requires MSRV 1.70
version = "1,<=1.0.187"
features = ["c++17"]

[build-dependencies]
cmake = "0.1"
cxx-build = "1,<=1.0.129" # 1.0.130 requires MSRV 1.70
cxx-build = "1,<=1.0.187"
pkg-config = { version = "0.3", optional = true }

[dev-dependencies]
Expand Down
Loading