Skip to content

ci(desktop-release): use package-style release title#648

Merged
jeevanpillay merged 1 commit intomainfrom
ci/desktop-release-title-format
May 6, 2026
Merged

ci(desktop-release): use package-style release title#648
jeevanpillay merged 1 commit intomainfrom
ci/desktop-release-title-format

Conversation

@jeevanpillay
Copy link
Copy Markdown
Member

@jeevanpillay jeevanpillay commented May 6, 2026

Summary

Future `@lightfast/desktop@*` tag pushes will now produce GitHub release titles in the format `lightfast@`, matching the convention I applied retrospectively to the four ad-hoc dry-run RCs (renamed via `gh release edit` to `lightfast@0.1.0-alpha.1` through `lightfast@0.1.0-alpha.4`).

Tag names are unchanged — only the human-facing title rendered on the release page.

Test plan

  • Diff is one line in `.github/workflows/desktop-release.yml`
  • Confirmed by next tag push: cutting `@lightfast/desktop@0.1.0-alpha.5` produces a release titled `lightfast@0.1.0-alpha.5`

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated release naming format for improved consistency and clarity.

Future tag pushes should produce GitHub release titles in the format
`lightfast@<version>` to match the convention applied retrospectively
to the four ad-hoc dry-run RCs (renamed to `lightfast@0.1.0-alpha.1`
through `lightfast@0.1.0-alpha.4`). Tag names themselves are unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lightfast-app Ready Ready Preview, Comment May 6, 2026 9:21am
lightfast-platform Ready Ready Preview, Comment May 6, 2026 9:21am
lightfast-www Ready Ready Preview, Comment May 6, 2026 9:21am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 013ed611-2c14-44ea-9991-e7595d0eb2a8

📥 Commits

Reviewing files that changed from the base of the PR and between 5f3a60e and 3096e68.

📒 Files selected for processing (1)
  • .github/workflows/desktop-release.yml

📝 Walkthrough

Walkthrough

Release draft title format changes from "Lightfast desktop v{version}" to "lightfast@{version}", with the version variable sourced from a local step instead of the prepare job output.

Changes

Release Title Update

Layer / File(s) Summary
Release Workflow
.github/workflows/desktop-release.yml
Draft release title format updated from "Lightfast desktop v{version}" to "lightfast@{version}"; version variable source switches from needs.prepare.outputs.version to steps.ver.outputs.version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Review flags:

[warning] Version source dependency shift: The change replaces the prepare job's version output with steps.ver.outputs.version. Verify that steps.ver is defined earlier in the workflow and produces identical version values. If the two sources diverge, this silently changes which version gets stamped on the release artifact.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title follows conventional commits format (ci: scope), is 52 characters (under 70 limit), and accurately describes the single-line change to release title formatting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/desktop-release-title-format
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch ci/desktop-release-title-format

Comment @coderabbitai help to get the list of available commands and usage tips.

@jeevanpillay jeevanpillay merged commit bf52e0f into main May 6, 2026
14 checks passed
@jeevanpillay jeevanpillay deleted the ci/desktop-release-title-format branch May 6, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant