Skip to content

fix(desktop): set MakerDeb/MakerRpm bin to lightfast #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeevanpillay wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix(desktop): set MakerDeb/MakerRpm bin to lightfast #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/desktop/forge.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,13 @@ const config: ForgeConfig = {
{
options: {
name: "lightfast",
// electron-installer-common defaults `bin` to `pkg.name`, which
// becomes `@lightfast/desktop` after the release workflow runs
// `npm version`. The actual binary on disk is `lightfast` (set via
// `packagerConfig.executableName` above). Without this override the
// maker fails: "could not find the Electron app binary at
// .../Lightfast-linux-<arch>/@lightfast/desktop".
bin: "lightfast",
productName: "Lightfast",
genericName: "Developer Tool",
maintainer: "Lightfast <releases@lightfast.ai>",
Expand All @@ -169,6 +176,9 @@ const config: ForgeConfig = {
{
options: {
name: "lightfast",
// Same `bin` override as MakerDeb above — electron-installer-redhat
// shares the same `getDefaultsFromPackageJSON` helper.
bin: "lightfast",
productName: "Lightfast",
genericName: "Developer Tool",
license: "MIT",
Expand Down
Loading