Skip to content

Conversation

@chiefcll
Copy link
Contributor

parentHasRenderTexture is initialized as false, so this always returns false.

@jfboeve jfboeve added the do not merge Do not merge this PR. It may not be ready or depends on another PR to be merged first. label Jan 13, 2026
@jfboeve
Copy link
Collaborator

jfboeve commented Jan 13, 2026

depends on: #693 My mistake. This PR has nothing to do with that.

@chiefcll
Copy link
Contributor Author

This doesn't depend on #693 - They are separate PRs.

Currently the renderer never reuses a RenderOp - on my demo I'm saving ~20% in draw calls.

@jfboeve
Copy link
Collaborator

jfboeve commented Jan 14, 2026

~20% O.o, that is nice.. let's clean the check up a bit:

if (
    params.parentHasRenderTexture === true && 
    this.curRenderOp.framebufferDimensions !== null && 
    params.framebufferDimensions !== null
  ) {
  if(
    this.curRenderOp.framebufferDimensions.w !== params.framebufferDimensions.w || 
    this.curRenderOp.framebufferDimensions.h !== params.framebufferDimensions.h
    ) {
    return false;
  }
}

this decreases the amount if !== null checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Do not merge this PR. It may not be ready or depends on another PR to be merged first.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants