actually fix the update loop not going idle #706
Merged
+15
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed renderState -> newRenderState to avoid confusion with this.renderState
When the node is out of bounds, we need to keep the updates for the next loop when its back in bounds.
The loop was caused by the updateParent being true which the out of bounds causes. Moving that after the return statements prevents parent from being updated which caused the loop.
Note - that updateParent had no effect in the previous loop as updateType was reset at the end of the loop. So should that be in there at all?