Skip to content

Conversation

@chiefcll
Copy link
Contributor

Renamed renderState -> newRenderState to avoid confusion with this.renderState

  1. When the node is out of bounds, we need to keep the updates for the next loop when its back in bounds.

  2. The loop was caused by the updateParent being true which the out of bounds causes. Moving that after the return statements prevents parent from being updated which caused the loop.

Note - that updateParent had no effect in the previous loop as updateType was reset at the end of the loop. So should that be in there at all?

@chiefcll
Copy link
Contributor Author

I've tested removing

// if (updateParent === true) {
// parent!.setUpdateType(UpdateType.Children);
// }

And confirmed it has no effect in my app. Which makes sense as it was being cleared before.

@jfboeve jfboeve added this pull request to the merge queue Jan 14, 2026
Merged via the queue into lightning-js:main with commit 7a20b77 Jan 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants