Skip to content

[Custom Transactions] Add TxBuilder::get_next_commitment_stats #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 26, 2025
+553 −239
Merged

[Custom Transactions] Add TxBuilder::get_next_commitment_stats #3921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0a75f92
Add `TxBuilder::get_next_commitment_stats`
tankyleo Jul 31, 2025
3a3e7eb
Adjust dust exposure due to excess fees for clarity
tankyleo Aug 6, 2025
06ed9cb
Add `ChannelContext::get_next_{local, remote}_commitment_stats`
tankyleo Jul 31, 2025
48b412a
Improve prediction of commitment stats in `validate_update_add_htlc`
tankyleo Jul 31, 2025
3218db1
Improve prediction of commitment stats in `can_accept_incoming_htlc`
tankyleo Jul 31, 2025
d36fdab
Improve prediction of commitment stats in `validate_update_fee`
tankyleo Jul 31, 2025
124bd42
Improve prediction of commitment stats in `can_send_update_fee`
tankyleo Jul 31, 2025
8a1c9d9
Add validation of the fees predicted by `next_commitment_stats`
tankyleo Jul 31, 2025
f75812f
Delete dead `next_{local, remote}_commitment_tx_fee_info_cached`
tankyleo Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lightning/src/ln/chan_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ pub(crate) fn commit_tx_fee_sat(feerate_per_kw: u32, num_htlcs: usize, channel_t
}

/// Returns the fees for success and timeout second stage HTLC transactions.
pub(super) fn second_stage_tx_fees_sat(
pub(crate) fn second_stage_tx_fees_sat(
channel_type: &ChannelTypeFeatures, feerate_sat_per_1000_weight: u32,
) -> (u64, u64) {
if channel_type.supports_anchors_zero_fee_htlc_tx()
Expand Down
Loading
Loading