Skip to content

Conversation

@ZZiigguurraatt
Copy link
Contributor

  • Move integrated mode version table up and make title more clear.
  • Make remote mode compatibility title more clear.

@gemini-code-assist
Copy link

Summary of Changes

Hello @ZZiigguurraatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the clarity and organization of version compatibility information within the README.md file. The changes involve strategically relocating and renaming sections to distinctly separate integrated and remote mode daemon versioning details, thereby streamlining the process for users to quickly locate the specific compatibility information they need.

Highlights

  • Integrated Mode Version Table Relocation: The table detailing daemon versions packaged with LiT in integrated mode has been moved to an earlier, more prominent section of the README for improved visibility and accessibility.
  • Integrated Mode Title Clarification: The heading for the integrated mode version table has been updated to "Daemon Versions packaged with LiT in Integrated Mode" to explicitly clarify its context and purpose.
  • Remote Mode Compatibility Title and Link Update: The title for the remote mode compatibility section has been made more clear, and an internal link within this section was updated to accurately reflect the new heading of the integrated mode table.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the clarity of the README.md file by reorganizing the version compatibility information. The new sections for 'Integrated Mode' and 'Remote Mode' make it much easier for users to find the information relevant to their setup. My review includes a couple of minor suggestions to enhance the readability of the new headings.

README.md Outdated
If you’d prefer to compile from source code please follow [these instructions](./docs/compile.md).

## Compatibility
## Daemon Versions packaged with LiT in **_Integrated Mode_**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of both bold and italics (**_..._**) for emphasis on 'Integrated Mode' is a bit strong and can make the heading feel cluttered. Using only bold (**...**) is generally sufficient to draw attention and results in a cleaner look.

Suggested change
## Daemon Versions packaged with LiT in **_Integrated Mode_**
## Daemon Versions packaged with LiT in **Integrated Mode**

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Potentially consider this one, as the italic is potentially not ideal for headers.

Copy link
Contributor Author

@ZZiigguurraatt ZZiigguurraatt Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to ***bold italics*** because the github rendering is already bold for links, so it did not stand out unless it was italics too and this syntax seemed cleaner than my previous one.

Copy link
Contributor Author

@ZZiigguurraatt ZZiigguurraatt Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, github ignored _ italics _ only because it was bolding for the link.

Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great! Except some small comments.

README.md Outdated
If you’d prefer to compile from source code please follow [these instructions](./docs/compile.md).

## Compatibility
## Daemon Versions packaged with LiT in **_Integrated Mode_**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Potentially consider this one, as the italic is potentially not ideal for headers.

@lightninglabs-deploy
Copy link

@ViktorT-11: review reminder
@ZZiigguurraatt, remember to re-request review from reviewers when ready

Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after this has been rebased to include the new releases that have been added to the file. @ZZiigguurraatt, do you know how to rebase this, or would you like me to do that?

@ZZiigguurraatt
Copy link
Contributor Author

LGTM after this has been rebased to include the new releases that have been added to the file. @ZZiigguurraatt, do you know how to rebase this, or would you like me to do that?

I can rebase

@ZZiigguurraatt
Copy link
Contributor Author

LGTM after this has been rebased to include the new releases that have been added to the file. @ZZiigguurraatt, do you know how to rebase this, or would you like me to do that?

I can rebase

done

@ZZiigguurraatt ZZiigguurraatt force-pushed the readme_fix branch 2 times, most recently from 57df760 to 8bcd425 Compare November 19, 2025 17:01
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for an initial rebase! Unfortunately though, there seems to still be merge conflicts here, which you can see by the fact that CI isn't running + a reported merge conflict. You'd need to rebase this once more, and make sure that the HEAD your rebasing on, is that latest version of master.


| LiT | LND | Loop | Faraday | Pool | Taproot Assets |
|-------------------|--------------|--------------|---------------|--------------|----------------|
| **v0.15.3-alpha** | v0.19.3-beta | v0.31.5-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.1-alpha |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An entry for the v0.16.0-apha.rc1 seems to be lost in the rebase here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you merged some more commits after I rebased, so I'll have to re-do it again. Let me know when you can prioritize my merge before other changes to README.md and then I'll re-do it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants