-
Notifications
You must be signed in to change notification settings - Fork 109
README: make integrated and remote mode version information more clear #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ZZiigguurraatt
commented
Oct 13, 2025
- Move integrated mode version table up and make title more clear.
- Make remote mode compatibility title more clear.
Summary of ChangesHello @ZZiigguurraatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the clarity and organization of version compatibility information within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the clarity of the README.md file by reorganizing the version compatibility information. The new sections for 'Integrated Mode' and 'Remote Mode' make it much easier for users to find the information relevant to their setup. My review includes a couple of minor suggestions to enhance the readability of the new headings.
README.md
Outdated
| If you’d prefer to compile from source code please follow [these instructions](./docs/compile.md). | ||
|
|
||
| ## Compatibility | ||
| ## Daemon Versions packaged with LiT in **_Integrated Mode_** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of both bold and italics (**_..._**) for emphasis on 'Integrated Mode' is a bit strong and can make the heading feel cluttered. Using only bold (**...**) is generally sufficient to draw attention and results in a cleaner look.
| ## Daemon Versions packaged with LiT in **_Integrated Mode_** | |
| ## Daemon Versions packaged with LiT in **Integrated Mode** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Potentially consider this one, as the italic is potentially not ideal for headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to ***bold italics*** because the github rendering is already bold for links, so it did not stand out unless it was italics too and this syntax seemed cleaner than my previous one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, github ignored _ italics _ only because it was bolding for the link.
ViktorT-11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great! Except some small comments.
README.md
Outdated
| If you’d prefer to compile from source code please follow [these instructions](./docs/compile.md). | ||
|
|
||
| ## Compatibility | ||
| ## Daemon Versions packaged with LiT in **_Integrated Mode_** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Potentially consider this one, as the italic is potentially not ideal for headers.
|
@ViktorT-11: review reminder |
ViktorT-11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after this has been rebased to include the new releases that have been added to the file. @ZZiigguurraatt, do you know how to rebase this, or would you like me to do that?
I can rebase |
76dff22 to
62bbfc6
Compare
done |
57df760 to
8bcd425
Compare
8bcd425 to
7ac6a58
Compare
ViktorT-11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for an initial rebase! Unfortunately though, there seems to still be merge conflicts here, which you can see by the fact that CI isn't running + a reported merge conflict. You'd need to rebase this once more, and make sure that the HEAD your rebasing on, is that latest version of master.
|
|
||
| | LiT | LND | Loop | Faraday | Pool | Taproot Assets | | ||
| |-------------------|--------------|--------------|---------------|--------------|----------------| | ||
| | **v0.15.3-alpha** | v0.19.3-beta | v0.31.5-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.1-alpha | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An entry for the v0.16.0-apha.rc1 seems to be lost in the rebase here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you merged some more commits after I rebased, so I'll have to re-do it again. Let me know when you can prioritize my merge before other changes to README.md and then I'll re-do it again.