rfq: separate AuxChanNegotiator, AssetSalePolicy #1778
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor avoids storing a AuxChannelNegotiator reference in the AssetSalePolicy. Instead, it's gotten from the OrderHandler and passed as function arguments to where it's needed.
GeorgeTsagk
force-pushed
the
feature-bits
branch
from
74d98bf to
611a9fc
Compare
|
(Closing this one as we stuck with the original implementation.) |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor avoids storing a AuxChannelNegotiator reference in the AssetSalePolicy. Instead, it's gotten from the OrderHandler and passed as a function argument to wherever it's needed.
(@GeorgeTsagk feel free to pull this into your branch if it looks worthwhile, or just close if not.)