supplyverifier: store and verify non-issuer supply pre-commitments #1784

ffranr · 2025-09-09T10:53:14Z

This PR strengthens the supply commitment verification process by enforcing that initial supply commitments must spend pre-commitment outputs. This requirement ties the first supply commitment transaction directly to a mint anchor transaction.

Key changes:

Verification logic
- In supplyverifier, added an assertion that initial supply commitments must spend pre-commitment outputs. This ties the first supply commitment transaction directly to a mint anchor transaction, ensuring the chain of authentication is enforced for both local and remote issuances.
Database queries and schema
- Renamed existing queries to clearly distinguish between pre-commitments created by the local issuer (FetchUnspentMintSupplyPreCommits) and those created by remote issuers (FetchUnspentSupplyPreCommits).
- Added conditional upsert logic so that supply pre-commitments can be recorded when syncing issuance proofs for assets not issued locally.
tapdb enhancements
- Extended SupplyCommitMachine.UnspentPrecommits to return both local and remote issuer pre-commitments.

This change is

Rename SQL query to better align with "supply" terminology.

Rename SQL query UpsertMintAnchorUniCommitment to UpsertMintSupplyPreCommit. This gives room to add UpsertSupplyPreCommit in a later commit. Also, better align with "supply" terminology.

Rename SQL query FetchUnspentPrecommits to FetchUnspentMintSupplyPreCommits. This adds the term "Mint" to indicate that these supply pre-commitment entries relate to the local node's minting process. The rename also allows room to add FetchUnspentSupplyPreCommits in a subsequent commit.

Rename SQL query MarkPreCommitmentSpentByOutpoint to MarkMintPreCommitSpentByOutpoint. This adds the term "Mint" to indicate that these supply pre-commitment entries relate to the local node's minting process. The rename also allows room to add MarkPreCommitSpentByOutpoint in a subsequent commit.

Rename SQL table mint_anchor_uni_commitments to mint_supply_pre_commits. This aligns with the "supply" terminology and provides room to add a new supply pre-commits table for assets issued by a remote peer in a subsequent commit.

Extend FetchMintSupplyPreCommits to also return the supply pre-commit outpoint.

coveralls · 2025-09-09T11:18:49Z

Pull Request Test Coverage Report for Build 17626735389

Details

192 of 274 (70.07%) changed or added relevant lines in 12 files are covered.
97 unchanged lines in 14 files lost coverage.
Overall coverage decreased (-0.01%) to 56.974%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tapdb/burn_tree.go	5	8	62.5%
tapdb/supply_tree.go	3	6	50.0%
universe/supplycommit/env.go	6	11	54.55%
universe/supplyverifier/verifier.go	5	10	50.0%
tapdb/sqlc/supply_commit.sql.go	24	32	75.0%
tapdb/supply_commit.go	43	66	65.15%
tapdb/universe.go	74	109	67.89%

Files with Coverage Reduction	New Missed Lines	%
fn/context_guard.go	1	91.94%
asset/asset.go	2	79.97%
tapdb/addrs.go	2	78.23%
tapdb/sqlc/universe.sql.go	2	75.78%
tapdb/universe.go	2	79.86%
tapgarden/custodian.go	2	77.02%
commitment/tap.go	3	85.19%
proof/verifier.go	3	87.54%
mssmt/compacted_tree.go	4	77.19%
tapdb/assets_store.go	7	79.7%

Totals
Change from base Build 17562325369:	-0.01%
Covered Lines:	63308
Relevant Lines:	111118

💛 - Coveralls

tapdb/asset_minting_test.go

tapdb/sqlc/migrations/000046_supply_pre_commit_tables.up.sql

Roasbeef · 2025-09-09T22:53:32Z

universe/supplycommit/env.go

+func (s SupplySubTree) ToUniverseProofType() (universe.ProofType, error) {
+	switch s {
+	case MintTreeType:
+		return universe.ProofTypeMintSupply, nil


In order to unify things further, perhaps we update the String method of SupplySubTree to just return a call to the String() method of the corresponding ProofType.

This way these strings aren't defined in two palces as they are now.

Ah nice, good idea.

hmm ToUniverseProofType() returns an error where as SupplySubTree.String() does not. That's causing some problems. Would you mind if I put up a separate PR to refactor SupplySubTree perhaps?

tapdb/universe.go

tapdb/sqlc/queries/supply_commit.sql

Roasbeef · 2025-09-09T23:08:40Z

tapdb/supply_commit.go

@@ -326,6 +342,76 @@ func (s *SupplyCommitMachine) UnspentPrecommits(ctx context.Context,
 			preCommits = append(preCommits, preCommit)
 		}

+		// If any pre-commits were found where we acted as the issuer,


Perhaps this should just be another method? So one used for remote issuers, and one used for local issuers.

I’ve been considering that option. My reasoning for keeping a single UnspentPrecommits is twofold:

There shouldn’t be any overlap between remote- and locally-issued assets, so UnspentPrecommits can be called safely in either context.

Splitting into local/remote variants adds naming complexity. Terms like “remote pre-commit” aren’t self-explanatory, and including “issued” in the names makes them cumbersome.

What do you rekon i should do here?

tapdb/supply_commit_test.go

jtobin

This all looks very solid, and I haven't found any obvious issues. LGTM. 👍

ffranr · 2025-09-10T10:14:22Z

Added a fix commit to this PR, originally pointed out by @jtobin here: #1788

Add a table to store mint anchor transaction supply pre-commitment outputs for assets not issued by the local node. Data from this table will be used for supply commitment verification.

Adds support for upserting supply pre-commits that are not related to the minting process. These pre-commits pertain to assets issued by peer nodes.

Passes the proof type as an argument to universeUpsertProofLeaf rather than just its string representation. This refactor will simplify conditional logic based on proof type in a subsequent commit.

Extend universe leaf upsert with a method to conditionally upsert issuance supply pre-commitment records. This allows a node to record supply pre-commitments when syncing issuance proofs for assets it did not issue. These records are essential for verifying supply commitment transactions.

Introduce query to fetch unspent supply pre-commitment outputs. Each output originates from a mint anchor transaction and corresponds to an asset issuance where a peer node, not the local node, acted as the issuer. This differs from FetchUnspentMintSupplyPreCommits, which only returns pre-commitments minted by the local node.

Roasbeef

@Roasbeef reviewed 26 of 26 files at r1, 1 of 3 files at r3, 23 of 23 files at r4, all commit messages.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @ffranr)

universe/supplyverifier/verifier.go line 466 at r4 (raw file):

	}

	if issuanceProof.Asset.GroupKey.GroupPubKey !=

Should this be instead IsEqual?

Update method SupplyCommitMachine.UnspentPrecommits to return pre-commitment outputs generated by remote issuer nodes, in addition to those from the local node.

Now that supply pre-commitments are stored for remotely issued assets, we can assert in the supply verifier that if a supply commitment is the initial one (i.e., the spent commitment field is None), then the corresponding transaction must spend some pre-commitment outputs. This enforces a link between the initial supply commitment transaction and a mint anchor transaction.

ffranr · 2025-09-10T21:07:49Z

I’ve updated the group_key field in the new pre-commit SQL table to:

    -- The asset group key for this supply pre-commitment.
    -- Stored in canonical 32-byte x-only form as defined in BIP340
    -- (schnorr.SerializePubKey).
    group_key BLOB NOT NULL CHECK(length(group_key) = 32),

Roasbeef

LGTM 👙

ffranr added 7 commits September 8, 2025 22:43

tapdb: rename unit test functionality for new term "supply"

219ae69

tapdb: rename FetchMintAnchorUniCommitment to FetchMintSupplyPreCommits

a01ea2d

Rename SQL query to better align with "supply" terminology.

tapdb: rename query to UpsertMintSupplyPreCommit

a743144

Rename SQL query UpsertMintAnchorUniCommitment to UpsertMintSupplyPreCommit. This gives room to add UpsertSupplyPreCommit in a later commit. Also, better align with "supply" terminology.

tapdb: return supply pre-commit outpoint from FetchMintSupplyPreCommits

8f81e84

Extend FetchMintSupplyPreCommits to also return the supply pre-commit outpoint.

ffranr added this to the v0.7 milestone Sep 9, 2025

ffranr self-assigned this Sep 9, 2025

ffranr added this to Taproot-Assets Project Board Sep 9, 2025

github-project-automation bot moved this to 🆕 New in Taproot-Assets Project Board Sep 9, 2025

ffranr added database supply commit Work on the supply commitment feature, enabling issuers to attest to total asset supply on-chain. labels Sep 9, 2025

ffranr moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Sep 9, 2025

ffranr requested review from Roasbeef and jtobin September 9, 2025 12:00

ffranr mentioned this pull request Sep 9, 2025

supplyverifier: add pull syncer and non-universe node verification #1777

Merged

Roasbeef requested changes Sep 9, 2025

View reviewed changes

ffranr force-pushed the wip/supplyverify/store-nonissuer-supply-pre-commits branch from 8ffa1eb to 306bf35 Compare September 10, 2025 00:30

ffranr requested a review from Roasbeef September 10, 2025 00:30

jtobin mentioned this pull request Sep 10, 2025

universe: fix group key proof/leaf comparison #1788

Closed

jtobin approved these changes Sep 10, 2025

View reviewed changes

ffranr force-pushed the wip/supplyverify/store-nonissuer-supply-pre-commits branch from 306bf35 to 48336f5 Compare September 10, 2025 10:11

ffranr added 5 commits September 10, 2025 17:17

tapdb: add new table supply_pre_commits

f69da96

Add a table to store mint anchor transaction supply pre-commitment outputs for assets not issued by the local node. Data from this table will be used for supply commitment verification.

tapdb: add UpsertSupplyPreCommit query

7c99667

Adds support for upserting supply pre-commits that are not related to the minting process. These pre-commits pertain to assets issued by peer nodes.

tapdb: pass proof type into universeUpsertProofLeaf instead of string

1e481fa

Passes the proof type as an argument to universeUpsertProofLeaf rather than just its string representation. This refactor will simplify conditional logic based on proof type in a subsequent commit.

ffranr force-pushed the wip/supplyverify/store-nonissuer-supply-pre-commits branch from 48336f5 to c9081c0 Compare September 10, 2025 17:30

Roasbeef requested changes Sep 10, 2025

View reviewed changes

ffranr added 4 commits September 10, 2025 22:01

tapdb: extend UnspentPrecommits to include remote issuers

423306a

Update method SupplyCommitMachine.UnspentPrecommits to return pre-commitment outputs generated by remote issuer nodes, in addition to those from the local node.

supplyverifier: fix issuance leaf/proof group key comparison check

8770e5d

docs: add release notes

e8ea035

ffranr force-pushed the wip/supplyverify/store-nonissuer-supply-pre-commits branch from c9081c0 to e8ea035 Compare September 10, 2025 21:02

ffranr requested a review from Roasbeef September 10, 2025 21:14

Roasbeef approved these changes Sep 10, 2025

View reviewed changes

Roasbeef merged commit b25c053 into main Sep 10, 2025
18 of 19 checks passed

github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Sep 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

supplyverifier: store and verify non-issuer supply pre-commitments #1784

supplyverifier: store and verify non-issuer supply pre-commitments #1784

Uh oh!

ffranr commented Sep 9, 2025 •

edited by Roasbeef

Loading

Uh oh!

coveralls commented Sep 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Roasbeef Sep 9, 2025

Uh oh!

ffranr Sep 10, 2025

Uh oh!

ffranr Sep 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Roasbeef Sep 9, 2025

Uh oh!

ffranr Sep 10, 2025

Uh oh!

Uh oh!

jtobin left a comment

Uh oh!

ffranr commented Sep 10, 2025

Uh oh!

Roasbeef left a comment

Uh oh!

ffranr commented Sep 10, 2025

Uh oh!

Roasbeef left a comment

Uh oh!

Uh oh!

Uh oh!

supplyverifier: store and verify non-issuer supply pre-commitments #1784

supplyverifier: store and verify non-issuer supply pre-commitments #1784

Uh oh!

Conversation

ffranr commented Sep 9, 2025 • edited by Roasbeef Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 17626735389

Details

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Roasbeef Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

ffranr Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

ffranr Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Roasbeef Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

ffranr Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jtobin left a comment

Choose a reason for hiding this comment

Uh oh!

ffranr commented Sep 10, 2025

Uh oh!

Roasbeef left a comment

Choose a reason for hiding this comment

Uh oh!

ffranr commented Sep 10, 2025

Uh oh!

Roasbeef left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ffranr commented Sep 9, 2025 •

edited by Roasbeef

Loading

coveralls commented Sep 9, 2025 •

edited

Loading

ffranr Sep 10, 2025 •

edited

Loading