Use ada-url for URL operations in web APIs #1170
Open
+575
−300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add ada-url bindings.
This still doesn't use `state` since `state` doesn't allow us to iterate the nodes when releasing the memory and we need to call `URL.destructor` when freeing. In the future, we might omit getter allocations by making such change.
karlseguin
reviewed
Oct 22, 2025
| return parser.anchorSetHref(self, href); | ||
| } | ||
|
|
||
| // TODO return a disposable string |
There was a problem hiding this comment.
using the call_arena fixes this comment.
Suggested change
| // TODO return a disposable string |
| return parser.anchorSetHref(self, href); | ||
| } | ||
|
|
||
| // TODO return a disposable string |
There was a problem hiding this comment.
using the call_arena fixes this comment.
Suggested change
| // TODO return a disposable string |
| return parser.anchorSetHref(self, href); | ||
| } | ||
|
|
||
| // TODO return a disposable string |
There was a problem hiding this comment.
Suggested change
| // TODO return a disposable string |
| return error.NotProvided; | ||
| } | ||
|
|
||
| // TODO return a disposable string |
There was a problem hiding this comment.
Suggested change
| // TODO return a disposable string |
| return u.get_origin(page); | ||
| } | ||
|
|
||
| // TODO return a disposable string |
There was a problem hiding this comment.
Suggested change
| // TODO return a disposable string |
| return parser.anchorSetHref(self, href); | ||
| } | ||
|
|
||
| // TODO return a disposable string |
There was a problem hiding this comment.
Suggested change
| // TODO return a disposable string |
| return parser.anchorSetHref(self, href); | ||
| } | ||
|
|
||
| // TODO return a disposable string |
There was a problem hiding this comment.
Suggested change
| // TODO return a disposable string |
| </script> | ||
|
|
||
| <script id=invalidUrl> | ||
| let u = new URL("://foo.bar/path?query#fragment"); |
There was a problem hiding this comment.
what about testing if the error is thrown instead?
| const SetterError = error{Internal}; | ||
|
|
||
| return try std.mem.concat(arena, u8, &[_][]const u8{ "#", uriComponentNullStr(self.uri.fragment) }); | ||
| // FIXME: reinit search_params? |
There was a problem hiding this comment.
I sounds like we should reset and parse search params too indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves #1127's web API changes to this PR. We can swap-in to ada-url in CDP and close the initial PR once that become a necessity.
URL.HTMLAnchorElement.Closes #1111.