-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add metrics CLI filter, skip field, retry improvements, and infer endpoint #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e4ab579
b563026
4efda3c
8171fa2
ce00854
be8019d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,7 @@ | |
| DEFAULT_API_VERSION = "v1" | ||
| DEFAULT_API_TIMEOUT = 300 | ||
| DEFAULT_ENDPOINT_TYPE = "streaming" | ||
| SUPPORTED_ENDPOINT_TYPES = ["streaming", "query"] | ||
| SUPPORTED_ENDPOINT_TYPES = ["streaming", "query", "infer"] | ||
| DEFAULT_API_CACHE_DIR = ".caches/api_cache" | ||
|
|
||
| DEFAULT_API_NUM_RETRIES = 3 | ||
|
Comment on lines
+59
to
62
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inconsistent retry default: API retries still 3 while LLM retries bumped to 5. The PR description states default retry attempts were increased from 3 to 5, but 🤖 Prompt for AI Agents
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed — reverted
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only users with a collaborator, contributor, member, or owner role can interact with CodeRabbit. |
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t drop prepared request parameters for
/infer.Line 356 sends only
questionandinclude_metadata, soextra_request_paramsand other prepared request fields are ignored forendpoint_type == "infer". If/infersupports only a subset, filter explicitly instead of silently discarding everything.Proposed fix
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — added a code comment explaining that
extra_request_paramsare not forwarded to/infersince the endpoint only acceptsquestionandinclude_metadata. Other params (model, provider, etc.) are not part of the RLSAPI/inferAPI contract.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only users with a collaborator, contributor, member, or owner role can interact with CodeRabbit.