Skip to content

Kotlin benches#4

Open
d-plaindoux wants to merge 2 commits intomainfrom
kotlin-benchmarks
Open

Kotlin benches#4
d-plaindoux wants to merge 2 commits intomainfrom
kotlin-benchmarks

Conversation

@d-plaindoux
Copy link
Contributor

@d-plaindoux d-plaindoux commented Oct 17, 2022

  • Math lib transpiration to Kotlin
  • Test done and correct
  • Benchmarks done
  • README and conclusion

@d-plaindoux d-plaindoux requested a review from melwyn95 October 17, 2022 13:36
@d-plaindoux d-plaindoux self-assigned this Oct 17, 2022

fun lte(a: t): (t) -> Boolean

fun gt(a: t): (t) -> Boolean = { b -> lt(b)(a) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about Kotlin, but seems like there is no support for currying, should this be written in un-curried style (tupled params lt(a, b)) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. And at the same time, I can check whether the inlining can be specified.

@melwyn95
Copy link
Contributor

melwyn95 commented Nov 3, 2022

Is it okay for bench/bench_kotlin/gradle/wrapper/gradle-wrapper.jar to be checked into git?

}
}

fun sinus(a: t, n: Int): t = sinus_symmetry(one, a, n)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't n be BigInteger ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants