Open
Conversation
Chris53897
reviewed
Dec 8, 2025
| "enlightn/security-checker": "^1.11", | ||
| "enlightn/security-checker": "^1.11|^2.0", | ||
| "guzzlehttp/guzzle": "^5.3.2 || ^6.3.3 || ^7.0.1", | ||
| "matthiasnoback/symfony-dependency-injection-test": "^4.3 || ^5.0", |
Contributor
There was a problem hiding this comment.
^4.3 || ^5.0 || ^6.0 (but needs PHPUnit >10) Thats is a problem with phppunit-bridge
Collaborator
Author
There was a problem hiding this comment.
Yeah... I solved this in zenstruck/schedule-bundle#94 by allowing PHPUnit 10 but I'm not a fan as I've lost deprecation reporting the phpunit-bridge provides...
GromNaN
reviewed
Dec 8, 2025
Comment on lines
+12
to
+13
| '%%liip_monitor.check.apc_fragmentation.warning%%', | ||
| '%%liip_monitor.check.apc_fragmentation.critical%%', |
There was a problem hiding this comment.
I'm surprised by the double %%? They look like parameters, and %% is for escaped %.
Numeric values are expected.
Suggested change
| '%%liip_monitor.check.apc_fragmentation.warning%%', | |
| '%%liip_monitor.check.apc_fragmentation.critical%%', | |
| param('liip_monitor.check.apc_fragmentation.warning'), | |
| param('liip_monitor.check.apc_fragmentation.critical'), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blockers:
enlightn/security-checkertorequire-devlaminas/laminas-diagnostics#73