Open
Conversation
…bility) - Migrate all service definitions from XML to PHP format - Migrate routing from XML to YAML - Update LiipMonitorExtension and MailerCompilerPass to use PhpFileLoader - Update README with new routing.yaml reference XML configuration is deprecated in Symfony 7.4 and will be removed in Symfony 8.0. This change ensures bundle compatibility with upcoming Symfony versions.
Author
- Downgrade laminas/laminas-diagnostics to version 1.27 in composer.json - Expand version constraints for doctrine packages in require-dev - Add PHP 8.5 and Symfony 6.4 support in CI workflow, noting compatibility issues with laminas-diagnostics 1.28+
- Update CI configuration to handle Symfony 8.0 compatibility by removing incompatible dev dependency. - Adjust dependency installation process based on Symfony version. - Skip tests related to security advisory if the optional dependency is not installed. - Mark tests as incompatible with Symfony 8 where necessary.
- Add validation step in CI to ensure composer.json constraints are met for PHP 8.1 and Symfony 6.4 compatibility. - Enforce specific version requirements for laminas/laminas-diagnostics and restrict usage of enlightn/security-checker in require-dev.
- Introduce phpunit-symfony8.xml.dist for Symfony 8 CI jobs. - Update CI workflow to use the new PHPUnit configuration file. - Mark tests as incompatible with Symfony 8 where necessary to ensure proper test execution.
- Introduce config_symfony8.yml to define framework and liip_monitor settings for Symfony 8 compatibility. - Ensure the structure aligns with Symfony 7.x for consistency in testing.
- Include symfony/yaml in composer.json to support YAML parsing in Symfony 8. - Ensure compatibility with existing Symfony dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for PHP 8.5 and Symfony 8.x so the bundle can be used on the latest runtimes. Upgrades are independent: projects can adopt either, both, or stay on current versions.
Changes
PHP 8.5
laminas/laminas-diagnosticsfrom^1.9to^1.28so Composer can resolve a version that supports PHP 8.5 (1.27.x only supports up to 8.4).Symfony 8
^8.0for:symfony/framework-bundleasset,browser-kit,expression-language,finder,mailer,messenger,phpunit-bridge,twig-bundle8.0.*to the CI matrix.CI
dependency-versionsto usematrix.depsinstead ofinputs.deps.composer.jsonformatting (indent, key order).Testing
composer.jsonremains valid; existing PHP 8.1–8.4 and Symfony 6.4/7.x combinations unchanged.Notes
feature/replace-deprecated-xml. Merge that branch first, then change this PR's base tomainand merge.