Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
grok-superimage-1.0that centralizesn/size/response_formatso clients cannot override these for that model.superimageserver settings.Description
grok-superimage-1.0to the model registry inModelServiceand a server-side configuration section[superimage]inconfig.defaults.tomlto controln,size, andresponse_format.grok-superimage-1.0by adding_superimage_server_image_config()and routing image request handling to use the server config whenrequest.model == 'grok-superimage-1.0'inapp/api/v1/chat.py._safe_sse_stream()to stream SSE error payloads on exceptions and_streaming_error_response()to return one-shot SSE error responses for early failures inchat.py, and wrapped streaming returns to use these helpers.ImageWSStreamProcessorandImageStreamProcessor, and ensured a final empty chat chunk anddata: [DONE]are emitted when no final chunk was produced.transient_upstream()inapp/services/grok/utils/retry.pyand updated token retry logic inChatServiceto try alternative tokens on transient errors when alternatives exist.get_storagetoresolve_storageinadmin_api/config.pyand renamed the endpoint function toget_storage_mode()to avoid naming conflict and improve clarity.AppChatReversetimeout selection logic to preferchat.timeoutand fall back tovideo.timeout/image.timeoutwhen unset.app/static/admin/js/config.js, addedsuperimagefields and select controls forsizeandresponse_format, and updated READMEreadme.mdto documentgrok-superimage-1.0behavior.Testing
pytestagainst the modified codebase and existing tests; the test run completed successfully with no failures.grok-superimage-1.0uses server-siden/size/response_format(manual integration assertions in CI), which passed.Codex Task