Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
grok-superimage-1.0) with centralizedn/size/response_formatso clients cannot override those params.Description
grok-superimage-1.0inModelServiceand default config section[superimage]inconfig.defaults.tomlwithn,size, andresponse_formatkeys, and updatedreadme.mdand admin UI (app/static/admin/js/config.js) to expose these options.grok-superimage-1.0via_superimage_server_image_config()and used it during request validation instead of client-providedimage_configwhen that model is selected._safe_sse_stream()and_streaming_error_response()in the chat route to catch exceptions during async streams and emit SSEerrorevents (and[DONE]), and wrapped streaming returns fromImageGenerationService,ImageEditService,ChatService, andVideoServiceaccordingly; also added try/except around non-imageChatService/VideoServicecalls to return SSE error responses whenstreamis not explicitlyfalse.image.pyandimage_edit.py) now suppress intermediate partial previews for chat-format streams, track whether any chat chunk was emitted, and always emit a final empty chat chunk plusdata: [DONE]if no final chunk was produced.transient_upstream()detection inapp/services/grok/utils/retry.pyand used it inChatServiceto attempt alternative tokens on transient upstream failures; exported the symbol from the module.app/services/reverse/app_chat.pyto detect SOCKS schemes and pass them viaproxytocurl_cffiwhile usingproxiesfor HTTP(S) proxies, and adjusted timeout selection logic.get_storageby renaming the local resolver import toresolve_storageand the route toget_storage_mode.Testing
pytestand all tests passed.flake8/format checks) and they succeeded.Codex Task