Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
grok-superimage-1.0and server-side[superimage]config options (n,size,response_format) and wired them into the Chat API to force server-controlled image parameters for that model (app/services/grok/services/model.py,app/api/v1/chat.py,config.defaults.toml,readme.md)._safe_sse_stream,_streaming_error_response) and wrapped all streaming responses with them so clients receive structured SSE errors (app/api/v1/chat.py).superimageparameters whenmodel == grok-superimage-1.0and ensured streaming for that model only emits final images and preserves original image names for URL outputs (app/services/grok/services/image.py,app/services/grok/services/image_edit.py).UpstreamExceptionif still insufficient (image.blocked_parallel_attempts) (app/services/grok/services/image.py,config.defaults.toml, admin UI updates).app/services/reverse/ws_imagine.py).[DONE]marker for chat-formatted streams (app/services/grok/services/image.py,app/services/grok/services/image_edit.py).retry.max_retryfallbacks to 3 when unset (app/services/grok/utils/retry.py,app/services/grok/services/chat.py,app/services/grok/services/image.py,app/services/grok/services/image_edit.py).proxyandproxiesparameters for curl-cffi based on scheme and logging proxy usage, and simplified timeout selection (app/services/reverse/app_chat.py).get_storage->resolve_storage) and exposed storage mode endpoint name change; added admin UI fields and locales forsuperimageandblocked_parallel_attempts(app/api/v1/admin_api/config.py,app/static/admin/js/config.js).Testing
pytest(existing unit/integration tests) and no test failures were observed.grok-superimage-1.0uses server-controlled image parameters during request validation.Codex Task