Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
grok-superimage-1.0) that uses server-side image parameters and behaves differently in streaming chat output.Description
SUPERIMAGE_MODEL_ID = "grok-superimage-1.0", added the model toModelService, and added server-sidesuperimageconfig defaults inconfig.defaults.tomlplus corresponding admin UI controls and readme documentation._superimage_server_image_config()to enforce server-controlledn/size/response_formatforgrok-superimage-1.0and applied it in request validation paths so clientimage_configis ignored for that model._safe_sse_streamand_streaming_error_responseand used them to ensure streams yield structuredevent: errorpayloads forChat,Image,ImageEdit, andVideostreaming flows instead of a raw 5xx transport break. Video/Chat service calls are wrapped to return SSE error responses when streaming.image.blocked_parallel_attempts) and by passing amax_retrieshint to the WebSocket reverse; failure after recovery raises anUpstreamExceptionwith structured details.grok-superimage-1.0), ensure a final empty chat chunk is emitted when nothing else was streamed, and preserve original image filenames forgrok-superimage-1.0URL outputs (no-finalsuffix).transient_upstream) and made token-retry defaults tolerant (get_config("retry.max_retry") or 3), and added retry-on-transient behavior inChatServiceto rotate tokens when upstream errors are transient and alternative tokens exist.proxyvsproxiestocurl_cffiappropriately; also adjusted timeout selection logic.get_storageimport to avoid name clash and renamed the route helper toget_storage_mode.Testing
pytest -qand the modified unit/integration tests, and all tests passed.grok-superimage-1.0behavior, and they passed.Codex Task