Skip to content

🔥 Remove client-side TTS prefetch in favour of native app control #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
williamchong wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

🔥 Remove client-side TTS prefetch in favour of native app control #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions composables/use-native-audio-player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,6 @@ import { useEventListener } from '@vueuse/core'
export function useNativeAudioPlayer(isActive: Ref<boolean | undefined>): TTSAudioPlayer {
const handlers: Partial<{ [K in keyof TTSAudioPlayerEvents]: TTSAudioPlayerEvents[K] }> = {}
let loaded = false
let cachedSegments: TTSSegment[] = []
let cachedGetAudioSrc: ((segment: TTSSegment) => string) | null = null

function prefetchSegment(index: number) {
if (!cachedGetAudioSrc || index < 0 || index >= cachedSegments.length) return
const url = cachedGetAudioSrc(cachedSegments[index]!)
// Fire-and-forget: warm server-side cache with minimal transfer.
// blocking=1 makes the server generate & cache the full buffer; Range
// header limits the response to 1 byte so we don't download the audio.
fetch(url, { headers: { Range: 'bytes=0-0' } }).catch(() => {})
}

function on<K extends keyof TTSAudioPlayerEvents>(event: K, handler: TTSAudioPlayerEvents[K]) {
handlers[event] = handler
Expand Down Expand Up @@ -43,7 +32,6 @@ export function useNativeAudioPlayer(isActive: Ref<boolean | undefined>): TTSAud
case 'trackChanged':
if (typeof detail.index === 'number') {
handlers.trackChanged?.(detail.index)
prefetchSegment(detail.index + 1)
}
break
case 'queueEnded':
Expand All @@ -53,7 +41,6 @@ export function useNativeAudioPlayer(isActive: Ref<boolean | undefined>): TTSAud
case 'remotePrevious':
if (typeof detail.index === 'number') {
handlers.trackChanged?.(detail.index)
prefetchSegment(detail.index + 1)
}
break
case 'error':
Expand All @@ -69,9 +56,6 @@ export function useNativeAudioPlayer(isActive: Ref<boolean | undefined>): TTSAud
rate: number
metadata: { bookTitle: string, authorName: string, coverUrl: string }
}) {
cachedSegments = options.segments
cachedGetAudioSrc = options.getAudioSrc

const origin = window.location.origin
const tracks = options.segments.map((segment, i) => ({
index: i,
Expand All @@ -87,7 +71,6 @@ export function useNativeAudioPlayer(isActive: Ref<boolean | undefined>): TTSAud
metadata: options.metadata,
})
loaded = true
prefetchSegment(options.startIndex + 1)
}

function resume(): boolean {
Expand All @@ -103,8 +86,6 @@ export function useNativeAudioPlayer(isActive: Ref<boolean | undefined>): TTSAud
function stop() {
postToNative({ type: 'stop' })
loaded = false
cachedSegments = []
cachedGetAudioSrc = null
}

function skipTo(index: number) {
Expand Down
Loading