Skip to content

fix: avoid duplicate READY message when shell is already running #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: avoid duplicate READY message when shell is already running #3462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/instance/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,13 @@
if *inst.Config.Plain {
logrus.Infof("READY. Run `ssh -F %q %s` to open the shell.", inst.SSHConfigFile, inst.Hostname)
} else {
// Check if a shell session is already running
if _, err := os.Stat(filepath.Join(inst.Dir, "ssh.pid")); err == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still testing, I'll revert back once fixed.

// Shell session exists, skip the READY message
_ = ShowMessage(inst)
err = nil

Check failure on line 320 in pkg/instance/start.go

View workflow job for this annotation

GitHub Actions / Lints 

ineffectual assignment to err (ineffassign)
return true
}
logrus.Infof("READY. Run `%s` to open the shell.", LimactlShellCmd(inst.Name))
}
_ = ShowMessage(inst)
Expand Down
Loading