-
Notifications
You must be signed in to change notification settings - Fork 696
Remove VMType check from the lima-init boot script #3861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
afbjorklund
wants to merge
1
commit into
lima-vm:master
Choose a base branch
from
afbjorklund:lima-init
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Aug 19, 2025
AkihiroSuda
reviewed
Aug 19, 2025
AkihiroSuda
reviewed
Aug 19, 2025
AkihiroSuda
reviewed
Aug 19, 2025
AkihiroSuda
reviewed
Aug 19, 2025
Do this when setting up the cidata instead, next to the decision on whether to use "cidata" dir or "cidata.iso". This means that this particular boot script is not depending on the driver, but can be used from all container drivers. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
This should be returned by the driver, instead of hardcoded on driver name like now: func useCloudInit(instConfig *limayaml.LimaYAML) bool {
// all drivers but WSL2 use cloud-init
return *instConfig.VMType != limayaml.WSL2
} Not so keen on the variable name, but it does follow the "default is false" convention. |
AkihiroSuda
reviewed
Aug 26, 2025
@@ -116,6 +116,11 @@ func setupEnv(instConfigEnv map[string]string, propagateProxyEnv bool, slirpGate | |||
return env, nil | |||
} | |||
|
|||
func useCloudInit(instConfig *limayaml.LimaYAML) bool { | |||
// all drivers but WSL2 use cloud-init | |||
return *instConfig.VMType != limayaml.WSL2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Should be moved to the DriverFeatures
struct in the driver infra)
Needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this when setting up the cidata instead, next to the decision on whether to use "cidata/" directory or "cidata.iso".
This means that this particular boot script is not depending on the driver, but can be used from all container drivers.
Apple Container external driver for macOS #3839
Kata/Docker Container external driver for Linux #3840
We probably want to add an explicit
bool
config for it to the driver, instead of checking for the driver name?And there are still some features left to add to the script (from cloud-config), like the hostname and timezone.
Currently we dont use
user-data
, butlima.env
(+ ssh key)We execute this script through the
boot.sh
directly (lima-init).