add timeout to cloud init progress monitoring #3904
Conversation
olamilekan000
force-pushed
the
add-timeout-context-to-progress-monitoring
branch
4 times, most recently
from
9a5bf59 to
4c19c9a
Compare
| @@ -292,6 +300,17 @@ func (a *HostAgent) emitEvent(_ context.Context, ev events.Event) { | |||
| } | |||
| } | |||
|
|
|||
| func (a *HostAgent) emitCloudInitProgressEvent(ctx context.Context, progress *events.CloudInitProgress) { | |||
| a.statusMu.RLock() | |||
| currentStatus := a.currentStatus | |||
olamilekan000
force-pushed
the
add-timeout-context-to-progress-monitoring
branch
from
4c19c9a to
38e2c38
Compare
pkg/hostagent/hostagent.go
Outdated
| defer func() { | ||
| if cmd.Process != nil { | ||
| logrus.Debug("Cleaning up cloud-init monitoring process") | ||
| cmd.Process.Kill() |
There was a problem hiding this comment.
This code will never be executed because it won't reach here until the tail process stops in the VM.
There was a problem hiding this comment.
Fixed it
olalekanodukoya@lima-defaultz:/Users/olalekanodukoya/works/opensource/lima$ ps aux | grep tail
olaleka+ 1704 33.3 0.0 6672 1920 pts/0 S+ 06:49 0:00 grep --color=auto tail
There was a problem hiding this comment.
confirmed that ssh process for tail killed. 👍
olamilekan000
force-pushed
the
add-timeout-context-to-progress-monitoring
branch
from
38e2c38 to
94933aa
Compare
Signed-off-by: olalekan odukoya <odukoyaonline@gmail.com>
olamilekan000
force-pushed
the
add-timeout-context-to-progress-monitoring
branch
from
94933aa to
3f8402c
Compare
AFIK, It does. When the Go compiler sees the same string literal (e.g., "Failed to create stdout pipe for cloud-init monitoring") multiple times in the source code, it doesn’t generate a new copy of that string every time. Instead, it puts one copy of that string in the program’s read-only data segment, and every usage just points to it. |
|
Thanks! 🙏🏻 |
fixes issue