add filter option to list command #4187
Conversation
olamilekan000
force-pushed
the
add-filter-opttion-to-list-cmd
branch
2 times, most recently
from
4601c97 to
c7631d4
Compare
cmd/limactl/list.go
Outdated
| } | ||
| if len(filter) != 0 { | ||
| for _, f := range filter { | ||
| yq = append(yq, "select("+f+")") |
There was a problem hiding this comment.
I tested numerous escaping approaches as asked, but it breaks the yq expressions. What string escape approach would you recommend? Thanks @AkihiroSuda
There was a problem hiding this comment.
@AkihiroSuda I don't see why this needs escaping. The filter expression should be inserted literally inside the select().
There was a problem hiding this comment.
Without escaping the code looks vulnerable to "Bobby Tables".
Unlikely to result in breaking data in our case though
There was a problem hiding this comment.
How is this different from any code you specify via --yq? The only difference is that the --filter argument is wrapped inside a select() call.
The user can literally send the same command via --yq "$(printf "select(%s)" "$FILTER")".
Any escaping would simply break the filter expression.
| if len(yq) != 0 { | ||
| return errors.New("option --filter conflicts with option --yq") | ||
| } |
There was a problem hiding this comment.
I think you should be able to combine --filter and --yq as long as the output format is json or yaml.
So you could just drop the check here because yq is already incompatible with the other output formats.
There was a problem hiding this comment.
This isn't too clear to me but is there anything wrong with the way it currently is?
cmd/limactl/list.go
Outdated
| } | ||
| if len(filter) != 0 { | ||
| for _, f := range filter { | ||
| yq = append(yq, "select("+f+")") |
There was a problem hiding this comment.
@AkihiroSuda I don't see why this needs escaping. The filter expression should be inserted literally inside the select().
olamilekan000
force-pushed
the
add-filter-opttion-to-list-cmd
branch
2 times, most recently
from
1c7ed74 to
404b08c
Compare
Signed-off-by: olalekan odukoya <odukoyaonline@gmail.com>
olamilekan000
force-pushed
the
add-filter-opttion-to-list-cmd
branch
from
404b08c to
a5ba9ad
Compare
3 participants
Fixes