feat: adding t-test estimators #437
Conversation
MarIniOnz
requested review from
FloLimebit,
LauraBoenchenLB,
OFranke and
philippgrosser
|
Thank you for your pull request! 🎉 Please make sure to read the pull request guidelines at: https://www.medmodels.de/docs/latest/developer_guide/pull-request.html While you're waiting for a review, please ensure that:
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
JabobKrauskopf
requested review from
Copilot
and removed request for
LauraBoenchenLB
There was a problem hiding this comment.
Pull Request Overview
This PR adds a t-test estimator implementation to support the RHGIOP functionality. The t-test compares means between treatment and control groups to determine statistical significance.
- Implements t-test function with configurable equal variance assumption
- Adds comprehensive test coverage for the new estimator
- Integrates t-test into the existing continuous estimators framework
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| medmodels/treatment_effect/continuous_estimators.py | Implements the core t-test function with EqualVariance enum and adds it to the estimator registry |
| medmodels/treatment_effect/estimate.py | Adds t-test method to the estimate class interface |
| tests/treatment_effect/test_continuous_estimators.py | Comprehensive test cases including valid scenarios and error handling |
| tests/treatment_effect/test_estimate.py | Integration test for t-test estimator |
| medrecord, | ||
| node_index, | ||
| outcome_group, | ||
| time_attribute="time", |
There was a problem hiding this comment.
The time_attribute parameter is hardcoded to "time" instead of using the function parameter. This should be time_attribute=time_attribute to maintain consistency with the treated_outcomes section above.
| time_attribute="time", | |
| time_attribute=time_attribute, |
The RHGIOP needs a t-test estimator to work. It is implemented here with its corresponding tests.